Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apple Silicon Support #438

Closed
toshmukhamedov opened this issue Oct 1, 2023 · 10 comments
Closed

Apple Silicon Support #438

toshmukhamedov opened this issue Oct 1, 2023 · 10 comments
Labels
enhancement New feature or request macos MacOS-specific issues

Comments

@toshmukhamedov
Copy link

Please consider adding Apple Silicon support to the PSST to optimize performance and energy efficiency for users with Apple Silicon-powered devices. This would enhance the overall user experience and ensure compatibility with Apple's latest hardware architecture.
@myInstagramAlternative
Copy link

+1

@Insprill
Copy link
Collaborator

Insprill commented Oct 3, 2023

I've created a PR adding an Apple Silicon target to the CI pipeline. You can check it out here, please let me know if it works.

@Insprill Insprill linked a pull request Oct 3, 2023 that will close this issue
Add CI builds for Apple Silicon #441
Closed
@Insprill Insprill added enhancement New feature or request macos MacOS-specific issues labels Oct 4, 2023
@toshmukhamedov
Copy link
Author

@Insprill I also tried this Psst-aarch64-apple-darwin build and it's still emulated
image

@jacksongoode
Copy link
Collaborator

Hmm, for some reason its being cross compiled wrong on the runners?

@Insprill
Copy link
Collaborator

Insprill commented Oct 6, 2023

Once the latest CI finishes please test again and see if it's fixed.

@nickolasclarke
Copy link

@Insprill this is still emulated with the latest artifact linked on the front page.
image

@Insprill
Copy link
Collaborator

Can anyone with an M1 and/or Intel mac test the CI build from #450 to confirm that it's working correctly and not being emulated?

@ralph
Copy link

ralph commented Jan 22, 2024

It works.

Bildschirmfoto 2024-01-22 um 19 52 06 Bildschirmfoto 2024-01-22 um 19 53 08

(Downloaded from here: https://github.com/jpochyla/psst/actions/runs/7612693455?pr=450)

@jacksongoode
Copy link
Collaborator

I think #450 would be good to merge and then we can close this @Insprill

@jacksongoode
Copy link
Collaborator

Closed with #450

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request macos MacOS-specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add CI builds for Apple Silicon jpochyla/psst
6 participants
@ralph @nickolasclarke @myInstagramAlternative @Insprill @jacksongoode @toshmukhamedov