Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builtin.jq: lpad, nwise #2777

Closed
wants to merge 1 commit into from
Closed

Conversation

pkoppstein
Copy link
Contributor

lpad: left pad
Retain _nwise for backward compatibility.

lpad: left pad
Retain _nwise for backward compatibility.
@nicowilliams
Copy link
Contributor

Retain _nwise for backward compatibility.

No need. If it starts with an _ then it's jq-private.

@pkoppstein
Copy link
Contributor Author

If it starts with an _ then it's jq-private.

True, but so far as I know, there's hardly any cost to retaining it for now, whereas removing it for a point release would probably just be aggravating to anyone like me who has many scripts that use it.

So my thought was: jettison it in 2.0 but in the meantime, isn't it nice to know there's some extra baggage that can be thrown overboard if that becomes necessary?

@pkoppstein pkoppstein requested a review from nicowilliams July 27, 2023 07:02
@wader
Copy link
Member

wader commented Jul 27, 2023

Should we open an issue discussing possible additional convenience builtins for post 1.7? but i think we should be careful to not clutter the namespace too much. nwise looks like a good candidiate, i have chunk in fq that works similar, would gladly replace it. See https://github.com/wader/fq/blob/master/doc/usage.md#function-added-in-fq for some other additional ones i've come to use a lot.

@nicowilliams
Copy link
Contributor

Should we open an issue discussing possible additional convenience builtins for post 1.7? but i think we should be careful to not clutter the namespace too much. nwise looks like a good candidiate, i have chunk in fq that works similar, would gladly replace it. See https://github.com/wader/fq/blob/master/doc/usage.md#function-added-in-fq for some other additional ones i've come to use a lot.

Yes, I think maybe we should adopt a change freeze so we can focus on making a release. This weekend I'll put time into re-generating the release key (or changing its name) and then making GitHub Actions workflows sign artifacts. Why not right now? Because I need a solid chunk of time to figure out the details. I find working with CI/CDs to be very time consuming. Working on features as time allows is much easier by comparison. I think release mechanics and misc bugs (and any other bugs found by fuzzing in the next few days) should be the only things we should focus on until we get a release done.

@nicowilliams nicowilliams modified the milestones: 2.0 release, sdf, 1.8 release Jul 27, 2023
@pkoppstein
Copy link
Contributor Author

Since one of the "checks" was (mysteriously) unsuccessful, and since this PR is already quite old,
and since I also wanted to add a stream-oriented nwise/2, I'm closing it in favor of #2786

In this superseding PR, I've dropped both _nwise/1 and _nwise/2 (in accordance with remarks made by @nicowilliams),
but I'd be happy to add either or both of them back.

@pkoppstein pkoppstein closed this Jul 29, 2023
@emanuele6 emanuele6 removed this from the 1.8 release milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants