Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlapping 15mins events that shouldn't overlap #1192

Closed
samlll42-github opened this issue Jan 25, 2019 · 2 comments
Closed

Overlapping 15mins events that shouldn't overlap #1192

samlll42-github opened this issue Jan 25, 2019 · 2 comments
Labels

Comments

@samlll42-github
Copy link

Hi everyone

Our calendar shows contiguous events that are displayed with an offset as if they overlap (although they do not overlap). This happens when we have contiguous event and one of them is 15 mins long.

We use step=5 and timeslots=12

I've seen a couple of ticket address this issue on previous versions but not clear what is the recommendation on this.

We've applied the following patch to workaround the issue for now. Did we miss something? is there a better way to address this issue? If not what do you guys think about making this configurable?

Thanks

diff --git a/src/DayColumn.js b/src/DayColumn.js
index 8771f3c..cd3c97e 100644
--- a/src/DayColumn.js
+++ b/src/DayColumn.js
@@ -177,7 +177,7 @@ class DayColumn extends React.Component {
       events,
       accessors,
       slotMetrics,
-      minimumStartDifference: Math.ceil((step * timeslots) / 2),
+      minimumStartDifference: Math.ceil((step * timeslots) / 4),
     })
 return styledEvents.map(({ event, style }, idx) => {
@uar-alin-vetian
Copy link

uar-alin-vetian commented Mar 11, 2019

Hello to all, I am having the same issues.
If I have 3 events starting one after the other, they are drawn like they overlap if the first one is less then 30 minutes.

I use step={5} timeslots={3}

event-overlap

@stale
Copy link

stale bot commented May 23, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants