Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All-day solt optional #2515

Closed
2 of 3 tasks
liaokaime opened this issue Feb 21, 2024 · 3 comments
Closed
2 of 3 tasks

All-day solt optional #2515

liaokaime opened this issue Feb 21, 2024 · 3 comments

Comments

@liaokaime
Copy link

Clear and concise description of the problem

image
Not everyone needs to display all-day solt, and there are times when I understand that all-day events will never occur, so it becomes a useless white space taking up space

Suggested solution

Add a parameter "showAllDay",true or false, default true.

Alternative

No response

Additional context

No response

Validations

  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Would you like to open a PR for this feature?

  • I'm willing to open a PR
@cutterbl
Copy link
Collaborator

Maybe not the answer that you want, but (for now) you can always override the .rbc-allday-cell class, setting it to display:none

@liaokaime
Copy link
Author

The way you said it works, and in fact that's what I did. But this means that users need to understand how the internal layout of react-big-calendar works, and I just think that for a library, the less the outside knows about the internal implementation details, the better

@cutterbl
Copy link
Collaborator

@liaokaime True. I'll put this on the feature request board for 'next' version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants