Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selectDates function is returning the end date as one day after the selected date #2563

Closed
5 tasks done
yalperg opened this issue Apr 7, 2024 · 0 comments
Closed
5 tasks done
Labels

Comments

@yalperg
Copy link
Contributor

yalperg commented Apr 7, 2024

Check that this is really a bug

  • I confirm

Reproduction link

n/a

Bug description

Demo:

Ekran.Kaydi.2024-04-08.01.59.53.mov

It seems like this line might be causing the issue.

end.setDate(slots[slots.length - 1].getDate() + 1)

This line was added to fix this #1909, but now the end date is not one day less, it's one day more. This line might not be needed anymore.

Expected Behavior

No response

Actual Behavior

No response

react-big-calendar version

1.11.3

React version

18.2.0

Platform/Target and Browser Versions

macOS

Validations

  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
  • Make sure this is a react-big-calendar issue and not an implementation issue

Would you like to open a PR for this bug?

  • I'm willing to open a PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant