fix: string.matches() and regex global flag (#450)

jquense · Apr 23, 2019 · a8935b7 · a8935b7
1 parent 1c18442
commit a8935b7
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/src/string.js b/src/string.js
@@ -86,7 +86,7 @@ inherits(StringSchema, MixedSchema, {
       test: value =>
         isAbsent(value) ||
         (value === '' && excludeEmptyString) ||
-        regex.test(value),
+        value.search(regex) !== -1,
     });
   },
 

diff --git a/test/string.js b/test/string.js
@@ -149,6 +149,21 @@ describe('String types', () => {
     ]);
   });
 
+  it('should check MATCHES correctly with global and sticky flags', function() {
+    var v = string().matches(/hi/gy);
+
+    return Promise.all([
+      v
+        .isValid('hi')
+        .should.eventually()
+        .equal(true),
+      v
+        .isValid('hi')
+        .should.eventually()
+        .equal(true),
+    ]);
+  });
+
   it('MATCHES should include empty strings', () => {
     let v = string().matches(/(hi|bye)/);