fix: defined() so it doesn't mark a schema as nullable

BREAKING CHANGE: defined() now doesn't automatically allow null, this was a bug. to mimic the old behavior add nullable() to schema with defined()
jquense · Nov 19, 2020 · f08d507 · f08d507
1 parent 57d42a8
commit f08d507
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/mixed.js b/src/mixed.js
@@ -592,7 +592,7 @@ const proto = (SchemaType.prototype = {
   },
 
   defined(message = locale.defined) {
-    return this.nullable().test({
+    return this.test({
       message,
       name: 'defined',
       exclusive: true,

diff --git a/test/mixed.js b/test/mixed.js
@@ -960,13 +960,13 @@ describe('Mixed Types ', () => {
 
     it('should pass when value is null', async () => {
       let inst = object({
-        prop: string().defined(),
+        prop: string().nullable().defined(),
       });
 
       await inst.isValid({ prop: null }).should.eventually().equal(true);
     });
 
-    it('should pass when value is not undefined nor null', async () => {
+    it('should pass when value is not undefined', async () => {
       let inst = object({
         prop: string().defined(),
       });