perf: reduce function calls for shallower stacks #1022
Conversation
|
|
||
| export default function createValidation(config) { |
There was a problem hiding this comment.
most wins due to simplifying this call by reducing indirection and inlining helpers
| import ValidationError from '../ValidationError'; | ||
| import { once } from './async'; | ||
|
|
||
| export default function runTests(options, cb) { |
There was a problem hiding this comment.
more big wins here, by making this function less clear with the loop but much shallower
|
This is excellent! I'm getting 96k req/s with the synchronous implementation (vs. joi's 157k) - well within striking range of joi (50%), and fast enough to not be the bottleneck for either express or fastify! Now when my servers run fast, I truly have no excuse but my crappy code xD I'd love to see further work on this, and I'm willing to even contribute performance regression tests if necessary. Thanks for doing this! |
That would be excellent and appreciated, having some benchmarks in the repo would be really helpful for tracking this stuff longer term. Doesn't need to be fancy just some numbers for yup to compare new versions against |
|
will get on it after work! |
starts to address #1017 bringing the benchmark for sync and async within striking distance of joi at least