Export MixedSchema to fix ts with --declarations #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ts error `Exported variable 'Schema' has or is using name 'MixedSchema' from external module "x/node_modules/yup/lib/mixed" but cannot be named.` with --declarations builds. The MixedSchema class needs to be exported so it can be used in declaration files.
|
I think this pr would solve #1162! |
|
Can we please merge this PR? |
|
Haven't had the time to try this out, but hoping to make some this week |
|
@jquense Looking forward to seeing it merged too 👍 |
|
+1 It's a simple change consistent to what e.g. object.d.ts or number.d.ts have, and no risk of regressions @jquense - the button "Merge" can just be pressed without even testing. |
|
every TS change needs to be tested, unfortunately @dko-slapdash the smallest change can have large, or to picture effects. |
|
Thanks @jquense ! |
|
@jquense Hi! When will the version with this patch be released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ts error
Exported variable 'Schema' has or is using name 'MixedSchema' from external module "x/node_modules/yup/lib/mixed" but cannot be named.with --declarations builds.The MixedSchema class needs to be exported so it can be used in declaration files.