fix: unix epoc bug in date parser #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jquense
approved these changes
Oct 16, 2019
|
awesome thanks! |
|
✨ This is an old work account. Please reference @brandonchinn178 for all future communication ✨ FYI this breaks all dates before the epoch now #731 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this fixes #234 and doesn't introduce any new buggy conditions.
I have modified return
value ? new Date(value) : invalidDate;toreturn value > -1 ? new Date(value) : invalidDate;keeping in mind any valid values will be greater than -1, (i.e 0 or above) and the invalid value likeNaNdoesn't satisfy> -1condition.