-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update readme to account for changes in types and add additional example #891
Conversation
@jquense I went ahead and updated the version in package.json as well as adding the entry to the changelog. I expect you may want to modify the changelog entry to your preference but I figured I would get it started. This should be ready to go and then we can merge the PR in DefinitelyTyped. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nit
package.json
Outdated
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "yup", | |||
"version": "0.28.5", | |||
"version": "0.29.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't bump the version, the release process will handle that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted that ✔️
Note: This is a draft PR because it should not be merged until DefinitelyTyped/DefinitelyTyped#44589 is merged.
defined
calls to thefirstName
andnickName
in the exampleoneOf`` without using the generic type parameter of
mixed` ([yup] Make typing for oneOf work to refine the schema type DefinitelyTyped/DefinitelyTyped#44573)Note: Does not change the version in package.json.