Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme to account for changes in types and add additional example #891

Merged
merged 5 commits into from
May 19, 2020

Conversation

iansan5653
Copy link
Contributor

Note: This is a draft PR because it should not be merged until DefinitelyTyped/DefinitelyTyped#44589 is merged.

Note: Does not change the version in package.json.

README.md Show resolved Hide resolved
@iansan5653 iansan5653 marked this pull request as ready for review May 15, 2020 18:19
@iansan5653
Copy link
Contributor Author

@jquense I went ahead and updated the version in package.json as well as adding the entry to the changelog. I expect you may want to modify the changelog entry to your preference but I figured I would get it started. This should be ready to go and then we can merge the PR in DefinitelyTyped.

Copy link
Owner

@jquense jquense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit

package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "yup",
"version": "0.28.5",
"version": "0.29.0",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't bump the version, the release process will handle that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted that ✔️

@jquense jquense merged commit e105a71 into jquense:master May 19, 2020
@iansan5653 iansan5653 deleted the task/updateReadme branch May 19, 2020 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants