Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent unhandled Promise rejection when returning rejected Promise inside test function #1327

Merged
merged 1 commit into from
Apr 4, 2021
Merged

fix: prevent unhandled Promise rejection when returning rejected Promise inside test function #1327

merged 1 commit into from
Apr 4, 2021

Conversation

danielrearden
Copy link
Contributor

Fixes #1326

@jquense jquense merged commit 5eda549 into jquense:master Apr 4, 2021
@jquense
Copy link
Owner

jquense commented Apr 4, 2021

Thanks!

@danielrearden danielrearden deleted the fix-async-validation branch April 4, 2021 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquense jquense jquense approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Returning a rejected Promise inside the test function results in an UnhandledPromiseRejection
2 participants
@danielrearden @jquense