Fix from #5382 causes failure: Full page dialog does not receive rounded corners - remove the fix and the rounded corners come back

[ShamimIslam]

1. Issue description
   Dialog pages (data-rel=dialog) pages with a popup (data-role=popup) fail to respond to the close button of the Dialog regardless of the state of the popup.
2. Test page
   http://jsfiddle.net/ShamimIslam/Y7VJC/
3. Steps to reproduce
   a. Create a JQM page, A with header, footer and a link, B (data-rel=dialog) to a second JQM page, C
   b. Create the second JQM page, C with header, a footer and a link, D, to a popup div E (data-role=popup)
   c. Create the popup div E in the content section of C.
   d. Put a header and content into E
   e. When done, the nesting should look like JQMDoc(A(header,content(B),footer),C(header,content(D,E),footer))
   f. Open the page and click the link B to get to the dialog C
4. Expected outcome
   The full page dialog has square corners - similer to the demos on Jquerymobile.com in the dialog section
5. Actual outcome
   The full page dialog will have rounded corners - unlike the demos on Jquerymobile. com in the dialog section
6. Firefox 17.0.1/Fedora 17/x86_64, Android Browser/Android ICS 4.0.4/Razr Maxx
7. JQM 1.2.0, JQuery 1.8.2
8. The previous fix to repair the close button behavior created this issue. Can also be seen when the structure is JQMDoc(A(header,content(B),footer),C(header,content,footer))

[ShamimIslam]

Nm - seems to work on the CDN version - may be something in the fixed .js

[ShamimIslam]

Fix from issue #5382 removes the rounded corners from the dialog C, but the popup E retains the rounded dialogs.

There seems to be a cascaded effect here.

[ShamimIslam]

Found the fix, don't know how to commit it.

Before fix:
.prepend().end()

After fix:
.first().prepend().end()

Correct fix:
.first().prepend().end().end()

.first() is a filter and as such needs to be removed before the rest of the chained actions.

[jaspermdegroot]

@ShamimIslam

I fixed the original issue on branch master (pre 1.3) and applied the same fix on branch 1.2-stable for the 1.2.1 release. Because we changed the way we apply corner styling for 1.3 the code on 1.2-stable is a bit different and I missed that I had to add another .end() there. Thanks a lot!

Closing as fixed by 113e3b4