Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ES2021 Logical Assignment #2082

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ljqx
Copy link
Contributor

@ljqx ljqx commented May 13, 2021

This PR fixes #2057.

  • scanner.ts is updated to accept &&=, ||=, ??=.
  • parser.ts is updated to treat &&=, ||=, ??= as assignment operator.
  • Unit tests and test-262 whitelist are updated.

@ljqx ljqx force-pushed the logical-assignment branch from 25a042e to f93a8cb Compare May 13, 2021 05:12
Copy link
Contributor

@lahma lahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ariya these changes look good and simple enough.

@lahma
Copy link
Contributor

lahma commented Aug 23, 2021

@ljqx can you please rebase this against master to make sure the optional attribute is not missing in the JSON tree presentation?

@lahma lahma mentioned this pull request Aug 25, 2021
@ljqx ljqx force-pushed the logical-assignment branch from f93a8cb to 7b6081b Compare September 7, 2021 01:00
@ljqx ljqx force-pushed the logical-assignment branch from 7b6081b to ef2e509 Compare September 9, 2021 16:34
@lahma
Copy link
Contributor

lahma commented Sep 19, 2021

@ariya I've tested this on .NET side and successfully integrated to Jint codebase, passing all tests related to logical assignment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

ES2021 Logical Assignment
2 participants