Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download, cache, and display links to remote images #316

Open
contrapunctus-1 opened this issue Feb 9, 2018 · 7 comments
Open

Download, cache, and display links to remote images #316

contrapunctus-1 opened this issue Feb 9, 2018 · 7 comments

Comments

@contrapunctus-1
Copy link

contrapunctus-1 commented Feb 9, 2018

It'd be nice if markdown-mode downloaded images from remote links, cached them and displayed them inline. Among other things, this would match the functionality of Markor on Android, and thus let one work with the same files on the phone and on the desktop (e.g. when synced via Syncthing).

@asok
Copy link

asok commented Oct 20, 2018

@jrblevin do you know any other emacs package that does similar thing?

@asok
Copy link

asok commented Nov 1, 2018

I see that org-download does something similar. Too bad Emacs does not have this built in.

@vermiculus
Copy link
Contributor

See above. Are there test-cases I've missed? I've not been able to test with markup like ![alt][url]\n\n[url]: https://example.com/some.png.

@frankgerhardt
Copy link

I came here because the book is on sale https://leanpub.com/markdown-mode/c/feb2019sale
Currently I'm not using Emacs for Markdown but this looks really good.
However it's a bit frustrating to read about features that are implemented but not yet released #385.

@contrapunctus-1
Copy link
Author

@vermiculus thanks for working on this! I tried it out, and it seems to work decently - congratulations 🙂 It seems it's not asynchronous, though, so one has to wait until all the images in the file are loaded.

@vermiculus
Copy link
Contributor

that would be a nice addition :-)

@sten0
Copy link

sten0 commented Apr 29, 2020

If/when this is implemented, please provide a defcustom with two or three states. One state would support this new behaviour, another would disable it, and it would be nice to have a third that would only fetch resources with user input of some kind. Why?

There is a vocal group of people who would like to be able to view and edit markdown files without having to wonder "will viewing this file 'phone home' to a server somewhere". Also, within a Debian context it means this type of privacy-breach-generic link will become serious if links are fetched without user interaction, and a consequence of this would be patching or removal of all such links in provided markdown documentation. That's a lot of work, and I expect most upstream projects would not be happy with such an outcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants