-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Suggestion] Consider using a "responsive" display property for the separator in markdown-view-mode #753
Comments
Thank you for reporting issue. I think this is a bug in CJK language configuration. Please see #755. And thanks for suggestion however your idea is not work if terminal or fonts don't support strike-throught characters. |
The documentation text is rendered by eglot prior to be displayed by eldoc-box in a smaller window, so if the separator doesn't adjust to window width automatically, it'll always stick out. Maybe you can implement the rendering differently based on terminal vs GUI? Strike-though don't need font support. That's your call, and feel free to close this :-) |
Wouldn't it make sense to adapt |
Hey, then don't use strike-through when it's not support. Just add something that is supported and be sure to put Using |
I have merged #757. Please check latest version |
Since eglot uses markdown-view-mode for rendering the documentation, the separator is often too long when the documentation put into a small child frame for display:
Expected Behavior
It would be nicer if the separator is "responsive": it changes width according to the viewing window's width:
Idea
We can render the separator with the
display
property set to(space :width text)
, which displays a space as long as the text portion of the window, plus aface
property set to(: strike-through t)
, which renders a horizontal line across the whole white space.For the code I used for the screenshot in the Expected behavior section, see casouri/eldoc-box#60
Thanks!
The text was updated successfully, but these errors were encountered: