Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxDeltaVeeVacuum bug #704

Open
wolffy-au opened this issue Mar 12, 2021 · 0 comments
Open

maxDeltaVeeVacuum bug #704

wolffy-au opened this issue Mar 12, 2021 · 0 comments

Comments

@wolffy-au
Copy link

wolffy-au commented Mar 12, 2021

I think you have a bug in ReachState.cs. Looks like the Actual and Vacuum checks are both using TotalDeltaVActual.

    private bool CheckVesselDeltaVeeActual(Vessel vessel)
    {
        double deltaVee = vessel.VesselDeltaV.TotalDeltaVActual;
        return deltaVee >= minDeltaVeeActual && deltaVee <= maxDeltaVeeActual;
    }

    private bool CheckVesselDeltaVeeVacuum(Vessel vessel)
    {
        double deltaVee = vessel.VesselDeltaV.TotalDeltaVActual;
        return deltaVee >= minDeltaVeeVacuum && deltaVee <= maxDeltaVeeVacuum;
    }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant