Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(v3) Specify "js-data-adapter" in "dependencies", not "devDependencies" #34

Open
zuzusik opened this issue Jul 5, 2016 · 2 comments
Open

Comments

@zuzusik
Copy link

zuzusik commented Jul 5, 2016

Now it is in devDependencies and this causes the following error, to fix which user is required to install js-data-adapter manually:

ERROR in projects/test-project/node_modules/js-data-localstorage/dist/js-data-localstorage.d.ts
(1,23): error TS2307: Cannot find module 'js-data-adapter'.
@zuzusik zuzusik changed the title (v3) Specify js-data-adapter in dependencies, not devDependencies (v3) Specify "js-data-adapter" in "dependencies", not "devDependencies" Jul 5, 2016
@jmdobry
Copy link
Member

jmdobry commented Jul 6, 2016

This is so TypeScript's typings work, not because js-data-localstorage needs to load js-data-adapter at runtime, as it's already built into dist/js-data-localstorage.js.

@zuzusik
Copy link
Author

zuzusik commented Jul 6, 2016

@jmdobry exactly

btw, noticed that in js-data-http js-data-adapter is specified in dependencies and so everything works as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants