Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doesn't support pylint >= 2 #8

Closed
kzidane opened this issue Nov 8, 2018 · 4 comments
Closed

doesn't support pylint >= 2 #8

kzidane opened this issue Nov 8, 2018 · 4 comments

Comments

@kzidane
Copy link

kzidane commented Nov 8, 2018

Looks like the latest pylint requires astroid>=2.0.0 and pylint-flask doesn't support that atm. Any plans to fix anytime soon?

Traceback (most recent call last):
  File "/opt/pyenv/versions/3.6.0/bin/pylint3", line 11, in <module>
    sys.exit(run_pylint())
  File "/opt/pyenv/versions/3.6.0/lib/python3.6/site-packages/pylint/__init__.py", line 19, in run_pylint
    Run(sys.argv[1:])
  File "/opt/pyenv/versions/3.6.0/lib/python3.6/site-packages/pylint/lint.py", line 1315, in __init__
    linter.load_plugin_modules(self._plugins)
  File "/opt/pyenv/versions/3.6.0/lib/python3.6/site-packages/pylint/lint.py", line 519, in load_plugin_modules
    module = modutils.load_module_from_name(modname)
  File "/opt/pyenv/versions/3.6.0/lib/python3.6/site-packages/astroid/modutils.py", line 196, in load_module_from_name
    return load_module_from_modpath(dotted_name.split('.'), path, use_sys)
  File "/opt/pyenv/versions/3.6.0/lib/python3.6/site-packages/astroid/modutils.py", line 239, in load_module_from_modpath
    module = imp.load_module(curname, mp_file, mp_filename, mp_desc)
  File "/opt/pyenv/versions/3.6.0/lib/python3.6/imp.py", line 244, in load_module
    return load_package(name, filename)
  File "/opt/pyenv/versions/3.6.0/lib/python3.6/imp.py", line 216, in load_package
    return _load(spec)
  File "<frozen importlib._bootstrap>", line 675, in _load
  File "<frozen importlib._bootstrap>", line 655, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 678, in exec_module
  File "<frozen importlib._bootstrap>", line 205, in _call_with_frames_removed
  File "/opt/pyenv/versions/3.6.0/lib/python3.6/site-packages/pylint_flask/__init__.py", line 79, in <module>
    MANAGER.register_transform(nodes.From,
AttributeError: module 'astroid.nodes' has no attribute 'From'
@carlio
Copy link

carlio commented Nov 24, 2018

This should just be a case of replacing 'nodes.From' with 'nodes.ImportFrom'? I will try to make a PR soon.

@antgel
Copy link

antgel commented Mar 16, 2019

This should be closed, as it was merged in PR #9 .

@jschaf
Copy link
Owner

jschaf commented Mar 18, 2019

Closing since I think it's done.

@jschaf jschaf closed this as completed Mar 18, 2019
@kzidane
Copy link
Author

kzidane commented Mar 18, 2019

Thank you! Appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants