-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tiddy up broke html ember script #283
Comments
js-beautify (which we use for tidying up) doesn't know what to do with those custom strings in place of normal properties, and this is the result of this. I wouldn't even know where to start modifying all the regular expressions for js-beautify to ignore these strings. |
Update the original post to display correctly in the github. The problem is <script> type is not a text/javascript type, so they should not be formatted using js-beautify. |
I don't have permission to reopen the issue. Hope you can receive the comments. |
js-beautify supports JS, HTML and CSS. |
We will not support it, however we might add support for the language in the future (not near thought - in beta) |
Having same problem, tidyup is formatting non-javascript script blocks:
maybe you can look at the script type and leave it be if not js. |
Provide a test-case fiddle please. |
jsbeautify has recently corrected this, can jsFiddle update their jsbeautify library? |
Will do after we will deal with this outage |
Still outage? |
Nope |
So fix on the way? |
Have the following in html frame,
<script type="text/x-handlebars" data-template-name="myTemplate">
<button {{action clickButton}} > MyButton1
{{view App.MyView placeholder="Input something 1 and enter"}}
</script>
Click tidy up, it's changed to wrong code:
<script type="text/x-handlebars" data-template-name="myTemplate">
< button {
{
action clickButton
}
} > MyButton1 < /button>
{{view App.MyView placeholder="Input something 1 and enter"}}
</script>
The text was updated successfully, but these errors were encountered: