Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/watchout/go/<cue> issues run command even when cue is not present #3

Open
5 tasks done
ptcr-marino opened this issue Jul 17, 2024 · 1 comment
Open
5 tasks done
Labels
bug Something isn't working

Comments

@ptcr-marino
Copy link

ptcr-marino commented Jul 17, 2024

Prerequisites

  • Using npm
  • Using an up-to-date main branch
  • Using latest version of devtools. Check the docs for how to update
  • Tried solutions mentioned in #400
  • For issue in production release, add devtools output of DEBUG_PROD=true npm run build && npm start

Expected Behavior

When issuing the command /watchout/go/{cue} over OSC, the application should not issue a run command if watchout returns an error that the cue named {cue} is not found. The expected behavior is present in osc-watchout which makes this a regression.

Current Behavior

The application blindly issues a run command in the same line as the gotoControlCue command, causing the timeline to start running even if the cue is not found.

Steps to Reproduce

  1. Send a /watchout/go/{cue} command where {cue} is a string that is not present in the watchout timeline as a control cue

Possible Solution (Not obligatory)

Check the response to gotoControlCue and branch if the response contains the string "error" - See the osc-watchout code for an example of the correct behavior.

@ptcr-marino ptcr-marino added the bug Something isn't working label Jul 17, 2024
@jshea2
Copy link
Owner

jshea2 commented Jul 23, 2024

Thanks for catching this. Here's v1.3.0 with the bug fix:
https://github.com/jshea2/OSC-for-WATCHOUT/releases/tag/v.1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants