Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logged in with no name #1

Open
lianmakesthings opened this issue Feb 27, 2017 · 2 comments
Open

Logged in with no name #1

lianmakesthings opened this issue Feb 27, 2017 · 2 comments

Comments

@lianmakesthings
Copy link

http://2017.jsunconf.eu/contriboot/#-KdzHT5MAsgfOTab9V9g
is missing the contributors name (which is incidentally me)

Also I am logged in as noname (which is probably why my contribution has no name)
screen shot 2017-02-27 at 12 20 44

@lianmakesthings lianmakesthings changed the title No name Logged in with no name Feb 27, 2017
@klyrr
Copy link
Member

klyrr commented Feb 27, 2017

Interesting.
I use the username from github returned data. And apparently you don't have a name in your github account :)

I'll look into it. Thanks!

@lianmakesthings
Copy link
Author

I figured it out, I think. I don't have a name set in my github profile, which is why it shows no name.

Expected: If no full name is set, fall back to github handle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants