-
-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for custom JSX renderer #894
Comments
While While we could add settings to map react jsx prop names to custom prop names, that's a lot of complexity to add for what feels like a very unwise use case. Can you elaborate on why you think deviating from the overwhelmingly defacto standard is worth it? |
Ok, I will try to list some arguments, I hope this is enough to convince you of this need :
Again, I understand that this if fairly complex, but I don't think that is is completely out of the scope of this plugin. I willing to help, since I'm very curious about writing custom eslint rules and better understanding AST. Anyway, thank you for your time and allowing me to state my reasoning. I hope this is enough, but if this is not, I understand and thank you for your work on this plugin raising awareness on a11y. |
Because for and class are reserved words, so you can’t destructure into those variable names. I hear your arguments, and it’s worth thinking about. |
Hello,
I have created a custom JSX renderer that take JSX code and output HTML.
This custom implementation doesn't use that exact same keyword.
For example, I use "class" instead of "className" and "for" instead of "htmlFor".
I noticed that there is a certain level of customization for the rules, can it be opened to support my needs, or do you want to strictly adhere to React implementation ?
I'm open to do the PR if needed.
Thank you very much for your time.
The text was updated successfully, but these errors were encountered: