False positive no-access-state-in-setstate when using this.state in a function called in the setstate callback

[Aequitas737]

Related to #1610, which doesn't completed catch all the cases.

With version 7.10.0 when the callback calls a function which references this.state.

myFunc = () => {
   this.setState({
            ...prop,
        }, () => this.doStuff());
    }

    doStuff= () => {
        console.log(this.state.asdf);
    }

Can work around this by just passing this.state into doStuff: this.doStuff(this.state)

[ljharb]

You definitely don't ever want to pass around the props or state object; we need to get this fixed.

[eric-wood]

Also seeing this, and have found I can work around it by using destructuring:

this.setState({ ...stuff }, () => {
  const { asdf } = this.state;
  console.log(asdf);
});

[jaybekster]

Has it been fixed?

[ljharb]

@jaybekster nope, that's why the issue is still open

[Jexah]

+1 for interest in fixing.

[jzabala]

Working properly with versions:

"babel-eslint": "^10.1.0"
"eslint": "^7.4.0"
"eslint-plugin-react": "^7.20.3"