Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write prerendered files to public dir #200

Closed

Conversation

AndrewLester
Copy link
Contributor

@AndrewLester AndrewLester commented Jan 14, 2023

Summary

Write prerendered files to the public dir. This PR also changes the temp dir to be .svelte-kit/svelte-adapter-firebase rather than .svelte-kit/.svelte-kit.

Relevant: #190

Other Information

I'm not sure if this even works because I haven't been able to test it myself. It also might need to turn on cleanUrls? This PR also doesn't handle prerendered redirects.

At best maybe someone can work off of this PR? Otherwise it can be closed if it's not useful.

EDIT: I turned on "cleanUrls" and now the /about and / routes are working. /todos doesn't work because somewhere prerendering isn't defined, and I'm not sure where that comes from.

pham added a commit to pham/svelte-adapter-firebase that referenced this pull request Jan 15, 2023
pham added a commit to pham/svelte-adapter-firebase that referenced this pull request Jan 16, 2023
@jthegedus jthegedus closed this Jan 17, 2023
jthegedus added a commit that referenced this pull request Jan 17, 2023
jthegedus added a commit that referenced this pull request Jan 17, 2023
jthegedus added a commit that referenced this pull request Jan 17, 2023
* chore: bump asdf tools

* chore: bump dependencies

* chore: apply xojs fixes

* test: bump test functions to nodejs18

* test: bump test deps & devdeps

* fix: rm check of runtime version assume nodejs18

* docs: update compat table

* test: fix end-to-end test firebase config

* chore(deps): Bump kit v1.1.1; ava, xo, esbuild, firebase-functions

* fix(lint): Use explicit `import type` statement

* fix(lint): Use the preferred nullish coalescing op over ternary

* test(version): Switch to `checkout@v3` to get rid of Node.js 12 warnings

* feat: Add Node.js 18 support

* fix: Missing 2nd argument for  (reading 'prerendering' error)

* fix(#200/@AndrewLester): Write prerendered fiels to public directory

* test(version): Add Node.js 18 to test cases

* fix(test): Add static route for `/about`. Switch from Svelte demo -> sverdle

* fix(test): Missing quote in `firebase.json`. Change label in test from Todos to Sverdle

Co-authored-by: Paul Pham <paul@aquaron.com>
@github-actions github-actions bot mentioned this pull request Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants