-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MagicDNS doesn't register hostnames with upper-case letters #363
Comments
Hmm, appears to work with tailscale ping, but not nslookup or ping in linux.. |
There's something funky somewhere.. Adding
|
In your opinion, should we normalize the Lines 242 to 264 in b1bd17f
|
@restanrm I think it depends where the actual issue with upper case letters affecting magicDNS is? It just needs to be done before wherever they get added to magicdns dns entries. (From what I can tell) |
Not sure if it's directly related to this issue, but my Android phone with hostname "Pixel 4a" (shown via |
I guess the magicdns should be conform to the RFC https://tools.ietf.org/html/rfc4343. Therefore we should accept uppercase letters in the dns name. |
If the issue is that uppercase is not accepted, then I think we should just lowercase it at that point, and let users have uppercase if they join with that. I think it would be too much a nightmare to deny uppercase. I would agree that all names should be unique in lowercase and therefor a normalise to lowercase before storing could make sense regardless. We need them to be unique |
@ohdearaugustin this RFC seems to have a lot of uncertainty about the behavior that we should expect (§4.2). Also if we apply this we should escape all special chars instead of replacing them (if I understand that RFC properly). |
Bug description
Machines are not added to MagicDNS if their hostname contains capital letters.
To Reproduce
tailscale up --login-server <URL> --auth-key <AUTH_KEY>
OR run
nslookup Foo-Bar
tailscale up --hostname=foo-bar --login-server <URL>
Context info
Let me know if this is a known issue or if anyone else can reproduce it. I have limited systems to test on.
Thank you!
The text was updated successfully, but these errors were encountered: