Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in HTTP API for 0.16.0-beta5 #681

Closed
routerino opened this issue Jul 19, 2022 · 1 comment · Fixed by #684
Closed

Regression in HTTP API for 0.16.0-beta5 #681

routerino opened this issue Jul 19, 2022 · 1 comment · Fixed by #684
Labels
bug Something isn't working

Comments

@routerino
Copy link

As of headscale 0.16.0-beta5, the HTTP API has stopped working. All calls to the API return an HTTP OK 200 code with no content. Versions before 0.16.0-beta5 work as expected.

See GIF below for working example (I've expired that API key since, for people thinking about being cheeky):

chrome_nJT3ZR1tCr
@routerino routerino added the bug Something isn't working label Jul 19, 2022
@routerino routerino changed the title Regression in HTTP API Regression in HTTP API for 0.16.0-beta5 Jul 19, 2022
@kradalby
Copy link
Collaborator

Looking at the change log, it looks like this broke when we dropped Gin as our web framework.

@juanfont can you have a look? If not I can by the end of the week.

@juanfont juanfont mentioned this issue Jul 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix API router juanfont/headscale
2 participants
@kradalby @routerino