Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename add_general_registry.jl to add_general_registry.runtests.jl #70

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Dec 20, 2022

This makes sure we are running the file from this action, and not an identically-named file from a different action.

@DilumAluthge DilumAluthge marked this pull request as ready for review December 20, 2022 00:16
@DilumAluthge DilumAluthge requested a review from a team as a code owner December 20, 2022 00:16
@DilumAluthge DilumAluthge requested review from IanButterworth and removed request for a team December 20, 2022 00:16
@codecov-commenter
Copy link

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (fe8e2a1) compared to base (7ea3b3e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #70   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            2         2           
=========================================
  Hits             2         2           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SaschaMann
Copy link
Member

I don't understand why this would be necessary, GITHUB_ACTION_PATH points to the repo of the action, not some shared workspace. They shouldn't interfere with each other.

@DilumAluthge DilumAluthge marked this pull request as draft June 19, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants