Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!all leads to java.lang.StringIndexOutOfBoundsException #111

Closed
snuyanzin opened this issue Aug 19, 2018 · 6 comments
Closed

!all leads to java.lang.StringIndexOutOfBoundsException #111

snuyanzin opened this issue Aug 19, 2018 · 6 comments

Comments

@snuyanzin
Copy link
Collaborator

After at least one connection is done !all fail as

java.lang.StringIndexOutOfBoundsException: String index out of range: -1
	at java.lang.String.substring(String.java:1931)
	at sqlline.Commands.all(Commands.java:1163)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at sqlline.ReflectiveCommandHandler.execute(ReflectiveCommandHandler.java:38)
	at sqlline.SqlLine.dispatch(SqlLine.java:791)
	at sqlline.SqlLine.begin(SqlLine.java:668)
	at sqlline.SqlLine.start(SqlLine.java:373)
	at sqlline.SqlLine.main(SqlLine.java:265)

@julianhyde
Copy link
Owner

The PR requires jline3 and therefore JDK 8, so we will not be including this in sqllline-1.5.0.

@julianhyde
Copy link
Owner

@arina-ielchiieva Did you make a comment on this issue? I got a notification, but now I can't find your comment.

@snuyanzin Does this fix require JDK 8 or jline3? We can include in 1.5 if it does not.

@arina-ielchiieva
Copy link
Collaborator

@julianhyde, I removed my comment, since found the answer to my question in other PR. As far as I understood you are going to include jline3 in the next release along with JDK 8 upgrade.

@snuyanzin
Copy link
Collaborator Author

@snuyanzin Does this fix require JDK 8 or jline3? We can include in 1.5 if it does not.

this issue and PR #112 does not require JDK 8

@julianhyde
Copy link
Owner

@snuyanzin OK, great. I'll include in 1.5 then.

@arina-ielchiieva Yes that's right. No jline3 in sqlline-1.5. I know it may be a controversial decision. I'll restart the thread on the Calcite dev list about release timing; please chime in there.

@julianhyde
Copy link
Owner

Fixed in 888fa72, PR #112. Thanks @snuyanzin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants