Script fails if first line is a comment

[JamesRTaylor]

To repro install Apache Phoenix 4.7 and run the following command:

./sqlline.py localhost ../examples/STOCK_SYMBOL.sql 

You'll see the following error message:

1/5          -- test comment
Aborting command set because "force" is false and command failed: "-- test comment"

Here's what the script looks like:

-- test comment
CREATE TABLE IF NOT EXISTS STOCK_SYMBOL (SYMBOL VARCHAR NOT NULL PRIMARY KEY, COMPANY VARCHAR);
UPSERT INTO STOCK_SYMBOL VALUES ('CRM','SalesForce.com');
SELECT * FROM STOCK_SYMBOL;

[JamesRTaylor]

Looks like it's only an issue if it's the first line in the .sql file.

[seva0stapenko]

In 4.4 (HDP 2.3/2.4) it's a problem with comments at the beginning, in the middle and at the end of the script. In 4.2 and prior SQL comments never were an issue (at least for HDP 2.0 through 2.2).
Since Hortonworks still ships phoenix 4.4 with their latest 2.4 release, would it be possible to create a patch for 4.4 branch?

[julianhyde]

@seva0stapenko While I work for hortonworks, sqlline is a project that I maintain as an individual. I don't think it is likely that hortonworks would issue a patch to fix a sqlline issue. First, maybe someone could contribute a patch to fix the issue. Then, it will at least appear in future versions of phoenix. And since sqlline is launched via a simple shell script, it should be possible to install a new sqlline without going through a formal back-port process.

[julianhyde]

Fixed in 20b1cce.

[julianhyde]

Also fixed the case where the first line of the script is empty or only spaces.

[JamesRTaylor]

Thanks, Julian!

[seva0stapenko]

As far as I can see, the fix did not make it into HDP 2.5.0. Scripts with the comments in the first line still cause sqlline to error out.

For my personal understanding, what is the relation between this repo and Apache Phoenix repo? If it's fixed here, will it be merged into Phoenix code-base at some point? Is there a Phoenix JIRA for this issue?

[julianhyde]

I haven't made a release of sqlline yet. I would make releases more often if there were more contributions.