Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimeoutError is not handled properly #131

Open
mmmommm opened this issue Apr 17, 2024 · 1 comment
Open

TimeoutError is not handled properly #131

mmmommm opened this issue Apr 17, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@mmmommm
Copy link
Contributor

mmmommm commented Apr 17, 2024

Description

TimeoutError is not handled properly and display Invalid response 504.

Normally, I would like error messages to be displayed on the UI of Jupyter when an error occurs, but it seems that the status code 504 is not being handled properly, and an error message saying 'invalid response 504' is displayed. When I changed it to RuntimeError, the error message started to be displayed correctly.

I haven't checked other places, so I don't know, but it might be happening elsewhere as well.

Reproduce

If the launch of the kernel server's k8s pod fails, handle_launch_timeout should be called from container.py to reproduce the issue.

Expected behavior

The appropriate error message is displayed.

@mmmommm mmmommm added the bug Something isn't working label Apr 17, 2024
Copy link

welcome bot commented Apr 17, 2024

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant