-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial test framework and tests #46
Merged
kevin-bates
merged 10 commits into
jupyter-server:main
from
kevin-bates:initial-test-framework
Jan 26, 2023
Merged
Initial test framework and tests #46
kevin-bates
merged 10 commits into
jupyter-server:main
from
kevin-bates:initial-test-framework
Jan 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from .yarn_client import YarnResource, yarn_resources | ||
|
||
|
||
class MockPopen(Popen): |
Check failure
Code scanning / CodeQL
Missing call to `__init__` during object initialization
Class MockPopen may not be initialized properly as [method Popen.__init__](1) is not called from its [__init__ method](2).
from mocks.yarn_client import MockResourceManager | ||
|
||
import gateway_provisioners | ||
from gateway_provisioners.k8s import client # noqa: F401 |
Check notice
Code scanning / CodeQL
Unused import
Import of 'client' is not used.
kevin-bates
added
maintenance
Repository maintenance
testing
Items related to testing
labels
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the initial test framework and a majority of the mocks necessary to test provisioners on Yarn, Kubernetes, and Docker{,Swarm}.
We will not close #21 at this time, but this does satisfy a checkbox or two on that issue.