Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial test framework and tests #46

Merged
merged 10 commits into from
Jan 26, 2023

Conversation

kevin-bates
Copy link
Member

This pull request adds the initial test framework and a majority of the mocks necessary to test provisioners on Yarn, Kubernetes, and Docker{,Swarm}.

We will not close #21 at this time, but this does satisfy a checkbox or two on that issue.

@kevin-bates kevin-bates mentioned this pull request Jan 26, 2023
6 tasks
from .yarn_client import YarnResource, yarn_resources


class MockPopen(Popen):

Check failure

Code scanning / CodeQL

Missing call to `__init__` during object initialization

Class MockPopen may not be initialized properly as [method Popen.__init__](1) is not called from its [__init__ method](2).
tests/mocks/k8s_client.py Fixed Show fixed Hide fixed
tests/mocks/yarn_client.py Fixed Show fixed Hide fixed
from mocks.yarn_client import MockResourceManager

import gateway_provisioners
from gateway_provisioners.k8s import client # noqa: F401

Check notice

Code scanning / CodeQL

Unused import

Import of 'client' is not used.
@kevin-bates kevin-bates added maintenance Repository maintenance testing Items related to testing labels Jan 26, 2023
@kevin-bates kevin-bates merged commit 9c4ce6c into jupyter-server:main Jan 26, 2023
@kevin-bates kevin-bates deleted the initial-test-framework branch January 26, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Repository maintenance testing Items related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests
1 participant