-
Notifications
You must be signed in to change notification settings - Fork 945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework Voila-ipywidgets interface #3443
Comments
That was the initial thought when starting voila-dashboards/voila#846. Since the lab-based Voila frontend will support prebuilt JupyterLab extensions, it could then pick up the prebuilt extension for ipywidget. But since the Voila frontend does not expose a Maybe Voila should still provide its own manager. The switch to a lab-based application will still be very breaking anyways so the update to ipywidgets 8 can make sense. |
Some relevant thoughts are explored more in #3429. I think most widget packages will support both ipywidgets 7 managers and ipywidgets 8 managers. Another approach then would be to load the ipywidgets 8 jlab widget manager, and load both the ipywidgets 7 core widgets and the ipywidgets 8 core widgets. The widget manager should use the appropriate package when called for. However, one problem with that is the CSS will conflict, so #3429 (comment) proposes scoping the 7.0 core widget css separate from the 8.0 core widget css. From #3429, it looks like VS Code is just determining which ipywidgets version to load initially. That would line up with your proposal of just loading whatever js was installed in the environment. |
👍 on this, I think it's reasonable to support only |
cc. @SylvainCorlay @jtpio @trungleduc
Problem
The current state is:
Proposed Solution
My proposal is to:
Currently I guess the jupyterlab-manager is too much related to the Notebook, but making it more general purpose could be good (so widgets could work with the jupyterlab notebook, voila, replite etc)
The text was updated successfully, but these errors were encountered: