Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional pre-commit install step #138

Open
blink1073 opened this issue Mar 27, 2022 · 0 comments
Open

Add optional pre-commit install step #138

blink1073 opened this issue Mar 27, 2022 · 0 comments

Comments

@blink1073
Copy link
Contributor

As we're switching more libraries to use pre-commit, it would be handy to have an option install pre-commit on editable installs. This should be a config option like:

[tool.jupyter-packaging]
install-pre-commit = True

That runs the following after the setuptools build_editable hook:

subprocess.run([sys.executable, '-m', 'pre_commit', 'install'])

We'd need to add a dependency on pre_commit, which is already on conda-forge.

This depends on #103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant