Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track linked extensions in extension manager #275

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

Zsailer
Copy link
Member

@Zsailer Zsailer commented Aug 18, 2020

This logic is missing in #248, so I've added it here.

The linked_extension property tracks if an extension has already been initialized and linked to a ServerApp. It was originally added for nbclassic when handling the shimming of server extensions. (This missing logic hasn't caused any issues because nbclassic is appending extensions directly to the private property, _linked_extensions).

This missing public-facing property became an issue when drafting jpserver-extension-check. I want to use this property to verify that extensions are linked properly in those tests.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@blink1073 blink1073 merged commit 33a523c into jupyter-server:master Aug 18, 2020
@blink1073 blink1073 added this to the 1.0 Release milestone Sep 17, 2020
Zsailer added a commit to Zsailer/jupyter_server that referenced this pull request Nov 18, 2022
* more clear status messages for pending kernels

* Bump to 0.15.0

* bug in provisioner
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
Track linked extensions in extension manager
@Zsailer Zsailer deleted the linked-extensions branch January 16, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants