Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook 7: meta-issue #726

Open
1 task
fcollonval opened this issue Oct 26, 2023 · 2 comments
Open
1 task

Notebook 7: meta-issue #726

fcollonval opened this issue Oct 26, 2023 · 2 comments
Labels

Comments

@fcollonval
Copy link
Collaborator

Here are some issues reported targeting notebook 7:

@vidartf
Copy link
Collaborator

vidartf commented Nov 17, 2023

Just for reference: What needs to be done on the nbdime side here?

@fcollonval
Copy link
Collaborator Author

fcollonval commented Nov 17, 2023

As notebook v7 is using the JupyterLab command defined there:

commands.addCommand(CommandIDs.diffNotebookCheckpoint, {

The issue comes from the isEnabled logic and the addition of the widget to the shell:

shell.add(widget);

As it will be a no-op in notebook v7: https://github.com/jupyter/notebook/blob/29d665dbac144d143d843168da9823cab6498b0a/packages/application/src/shell.ts#L318

There are ways to now if the extension is running within JupyterLab or Notebook:

  • having optional token dependency specific to one or the other
  • using the app.name (like in that extension e.g.)

Those could be used to tune the command behavior.


Related issue opened in notebook : jupyter/notebook#7134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants