Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update store_signature to check for duplicate signatures #99

Closed
Madhu94 opened this issue Aug 2, 2017 · 1 comment
Closed

Update store_signature to check for duplicate signatures #99

Madhu94 opened this issue Aug 2, 2017 · 1 comment
Milestone

Comments

@Madhu94
Copy link
Contributor

Madhu94 commented Aug 2, 2017

The store_signature method does not check if the signature is already in the store.

The primary key used here is id, so insert or ignore isn't really a check for duplicates. I think we should change the query to check if the signature exists first.

Not really an important issue - but still, thoughts ?

@takluyver
Copy link
Member

That makes sense to me

@Madhu94 Madhu94 changed the title Update store_signature to check for duplicates. Update store_signature to check for duplicate signatures Aug 2, 2017
@minrk minrk closed this as completed in #101 Aug 6, 2017
@minrk minrk added this to the 4.4 milestone Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants