-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace the use of toArray
by Array.from
#6774
Comments
jupyterlab-probot
bot
added
the
status:Needs Triage
Applied to issues that need triage
label
Mar 15, 2023
jtpio
added
maintenance
and removed
status:Needs Triage
Applied to issues that need triage
labels
Mar 15, 2023
Marking as a good first issue if someone would like to take a look! |
I'd like to work on this issue. Please assign it to me. |
Sure, thanks @tarunsamanta2k20! |
If the issue is still open, I would like to work on it. Please assign it to me |
Whoever wants to open a new PR please do! |
@revanthsonu @jtpio i submitted a pr. No need to create new PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
#6736 inadvertently brought the
toArray
utility from@lumino/algorithm
:notebook/packages/notebook-extension/src/trusted.tsx
Line 21 in 44eb35e
With Lumino 2, we should now be able to use
Array.from
instead.Which means this import can be removed here:
notebook/packages/notebook-extension/src/trusted.tsx
Line 7 in 44eb35e
The text was updated successfully, but these errors were encountered: