Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the use of toArray by Array.from #6774

Closed
jtpio opened this issue Mar 15, 2023 · 6 comments · Fixed by #6775
Closed

Replace the use of toArray by Array.from #6774

jtpio opened this issue Mar 15, 2023 · 6 comments · Fixed by #6775

Comments

@jtpio
Copy link
Member

jtpio commented Mar 15, 2023

#6736 inadvertently brought the toArray utility from @lumino/algorithm:

const cells = toArray(model.cells);

With Lumino 2, we should now be able to use Array.from instead.

Which means this import can be removed here:

import { toArray } from '@lumino/algorithm';

@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to issues that need triage label Mar 15, 2023
@jtpio jtpio added this to the 7.0 milestone Mar 15, 2023
@jtpio jtpio added maintenance and removed status:Needs Triage Applied to issues that need triage labels Mar 15, 2023
@jtpio
Copy link
Member Author

jtpio commented Mar 15, 2023

Marking as a good first issue if someone would like to take a look!

@SamantaTarun
Copy link
Contributor

I'd like to work on this issue. Please assign it to me.

@jtpio
Copy link
Member Author

jtpio commented Mar 15, 2023

Sure, thanks @tarunsamanta2k20!

@revanthsonu
Copy link

If the issue is still open, I would like to work on it. Please assign it to me

@jtpio
Copy link
Member Author

jtpio commented Mar 15, 2023

Whoever wants to open a new PR please do!

@SamantaTarun
Copy link
Contributor

@revanthsonu @jtpio i submitted a pr. No need to create new PR.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants