Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder Rename and Delete buttons remain during folder navigation #7329

Open
matthewgasbarro opened this issue Apr 17, 2024 · 1 comment
Open
Labels

Comments

@matthewgasbarro
Copy link

Description

When in the file browser view of Jupyter Notebook, double clicking a folder to view its contents displays the folder Rename and Delete buttons at the top of the file browser widget, but remain once the clicked folder's contents are displayed and no folders or files are checked.

Reproduce

  1. Go to File Browser
  2. Click on any folder. Notice the Rename and Delete buttons appear.
  3. Double click the folder
  4. See that Rename and Delete remain visible even though no folder or file is checked. Clicking on either button is a no-op.
  5. Checking any file or folder and then unchecking will cause the buttons to disappear.

Expected behavior

The Rename and Delete buttons should not be visible if no file or folder is checked.

Context

Notebook 7.1.2

chrome_3sYoVUvX7J

@matthewgasbarro matthewgasbarro added bug status:Needs Triage Applied to issues that need triage labels Apr 17, 2024
@RRosio RRosio removed the status:Needs Triage Applied to issues that need triage label Apr 23, 2024
@jtpio
Copy link
Member

jtpio commented May 1, 2024

Thanks @matthewgasbarro for reporting 👍

This is indeed an issue. Maybe we'll need something like jupyterlab/jupyterlab#14598 to be implemented in JupyterLab, to simplify the logic of which buttons should be displayed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants