Update CONTRIBUTING.md #7473
Open
Update CONTRIBUTING.md #7473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the filed with typos and correct grammar
|
|
|
Hello anyone there |
krassowski
suggested changes
Oct 4, 2024
| @@ -1,6 +1,6 @@ | |||
| # Contributing to Jupyter Notebook | |||
|
|
|||
| Thanks for contributing to Jupyter Notebook! | |||
| Thanks for showing interest on contributing to Jupyter Notebook! | |||
There was a problem hiding this comment.
This sounds like bad grammar to me, there is only one result on Google for "Thanks for showing interest on contributing to".
| @@ -72,7 +72,7 @@ jupyter notebook | |||
|
|
|||
| ### Local changes in Notebook dependencies | |||
|
|
|||
| The development installation described above fetches JavaScript dependencies from [npmjs](https://www.npmjs.com/), | |||
| The developmental installations described above fetches JavaScript dependencies from [npmjs](https://www.npmjs.com/), | |||
There was a problem hiding this comment.
Both "developmental" and "installations" sound incorrect in this context.
| @@ -199,8 +199,8 @@ You can invoke the pre-commit hook by hand at any time with: | |||
| pre-commit run | |||
| ``` | |||
|
|
|||
| which should run any autoformatting on your code | |||
| and tell you about any errors it couldn't fix automatically. | |||
| Which should run any autoformatting on your code | |||
There was a problem hiding this comment.
This is continuation of previous sentence so was right to my eye
| @@ -92,7 +92,7 @@ Notebook, acting as a local package repository. | |||
| With the previous example, it would be `yalc add @jupyterlab/ui-components`. | |||
| - Notebook is a monerepo, so we want this dependency to be 'linked' as a resolution (for all sub-packages) instead | |||
| of a dependency.\ | |||
| The easiest way is to manually move the new entry in _package.json_ from _dependencies_ to _resolutions_. | |||
| The easiest way is to do it is manually move the new entry in _package.json_ from _dependencies_ to _resolutions_. | |||
There was a problem hiding this comment.
The existing text sounds fine to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the filed with typos and correct grammar