Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final review of JEP #5

Closed
Zsailer opened this issue Jul 1, 2019 · 5 comments
Closed

Final review of JEP #5

Zsailer opened this issue Jul 1, 2019 · 5 comments

Comments

@Zsailer
Copy link
Member

Zsailer commented Jul 1, 2019

I'm going to do a final review of the documentation today (mostly to standardize emit vs. record_event in places), then I think we should submit this JEP to jupyter/enhancement-proposals tomorrow. Any objections? @jaipreet-s @yuvipanda

@jaipreet-s
Copy link
Collaborator

Sorry for the late reply. No objections! I'm actually in favor to just post the JEP as-is with some quick fixes and iterate. We're going to get feedback regardless.

@Zsailer
Copy link
Member Author

Zsailer commented Jul 5, 2019

Ok that's fine with me! You want to go ahead and submit the PR?

@jaipreet-s
Copy link
Collaborator

jaipreet-s commented Jul 5, 2019

Done, finally jupyter/enhancement-proposals#41

  • Could you cc relevant folks that have been interested in this?
  • Are you able to push commits to my fork to address feedback or make changes? If not, let me know and I'll configure permissions accordingly.

@Zsailer
Copy link
Member Author

Zsailer commented Jul 8, 2019

Great, thanks @jaipreet-s! I'll let you know if/when I run into issues pushing commits to your fork.

@jaipreet-s
Copy link
Collaborator

I've invited @Zsailer and @yuvipanda as "Collaborators" on my fork so you should be able to push. Let me know if there's another preferred way or the permissions aren't pushed. Additionally, I've @ tagged you guys on some of the feedback in the JEP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants