Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bug regarding image.name vs image.repository structure in values.yaml #116

Open
consideRatio opened this issue Jan 20, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@consideRatio
Copy link
Member

It seems to me that we have some invalid logic regarding use of name or repository as a key when updating values.yaml files with image tags.

chartpress/chartpress.py

Lines 27 to 28 in c1133e1

# name of possible repository keys used in image value
IMAGE_REPOSITORY_KEYS = {'name', 'repository'}

chartpress/chartpress.py

Lines 536 to 538 in c1133e1

for path_key, path_value in modifications.items():
if not isinstance(path_value, dict) or set(path_value.keys()) != {'repository', 'tag'}:
raise ValueError(f"I only understand image updates with 'repository', 'tag', not: {path_value!r}")

@consideRatio consideRatio added the bug Something isn't working label Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant