Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chartpress shouldn't modify version-controlled files #205

Open
manics opened this issue Mar 11, 2023 · 0 comments
Open

Chartpress shouldn't modify version-controlled files #205

manics opened this issue Mar 11, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@manics
Copy link
Member

manics commented Mar 11, 2023

Bug description

Many build tools avoid modifying version controlled source files, and instead write to a different output file. Chartpress modifies values.yaml in place, which means:

Expected behaviour

It should be possible to run chartpress without git diff showing changes

Possible options

a. Rename values.yaml to something like values.yaml.in (or values.template.yaml, or similar), following the pattern of autotools which generates Makefile from Makefile.in, remove values.yaml from source control
b. Recursively copy the source directory to a temporary directory and do all work in that directory.

(a) can be made backwards compatible if we want by modifying values.yaml in-place if the input file isn't found, whereas (b) requires no change to repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant