-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with Jupyter Server 2? #347
Comments
Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗 |
Thanks for opening this issue @jweill-aws I am seeing a problem when using JSP with Jupyter Server 2, but I believe it is a bug in Jupyter Server 2. Details can be found here: jupyter-server/jupyter_server#1012 |
This is the current test matrix jupyter-server-proxy/.github/workflows/test.yaml Lines 39 to 41 in a82f70a
I think changing jupyter_app to something like [notebook, jupyterserver1-lab, jupyterserver2-lab] could be worthwhile?
|
I think it would be helpful to explicitly test JS 2 combinations. I do have at least anecdotal evidence now that JSP work with JS2. |
Seems like there is an issue with the jupyterlab extension tests, but only that. See https://github.com/jupyterhub/jupyter-server-proxy/actions/runs/3642712327/jobs/6150126621. |
|
Has anyone tested jupyter-server-proxy with Jupyter Server version 2? This version is coming out soon, and users will expect to use the server proxy with it.
@ellisonbg @dlqqq @3coins
The text was updated successfully, but these errors were encountered: