Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Jupyter Server 2? #347

Closed
JasonWeill opened this issue Oct 5, 2022 · 6 comments
Closed

Compatibility with Jupyter Server 2? #347

JasonWeill opened this issue Oct 5, 2022 · 6 comments
Labels

Comments

@JasonWeill
Copy link

Has anyone tested jupyter-server-proxy with Jupyter Server version 2? This version is coming out soon, and users will expect to use the server proxy with it.

@ellisonbg @dlqqq @3coins

@JasonWeill JasonWeill added the bug label Oct 5, 2022
@welcome
Copy link

welcome bot commented Oct 5, 2022

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@ellisonbg
Copy link

Thanks for opening this issue @jweill-aws

I am seeing a problem when using JSP with Jupyter Server 2, but I believe it is a bug in Jupyter Server 2. Details can be found here: jupyter-server/jupyter_server#1012

@manics
Copy link
Member

manics commented Oct 6, 2022

This is the current test matrix

jupyterlab_version: [2, 3]
python: [3.6, 3.7, 3.8, 3.9]
jupyter_app: [notebook, lab]

I think changing jupyter_app to something like [notebook, jupyterserver1-lab, jupyterserver2-lab] could be worthwhile?

@ellisonbg
Copy link

I think it would be helpful to explicitly test JS 2 combinations. I do have at least anecdotal evidence now that JSP work with JS2.

@consideRatio
Copy link
Member

Seems like there is an issue with the jupyterlab extension tests, but only that.

See https://github.com/jupyterhub/jupyter-server-proxy/actions/runs/3642712327/jobs/6150126621.

@consideRatio
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants