ci: Replace Travis with GitHub workflow #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will require PyPI secrets to be setup |
|
This LGTM I'm conflicted about having the test build part of the release workflow as it feels misleading to run a test there, but i'm aware that it would lead to breaking of DRY if we had a dedicated test in the test workflow which isnt great either. We can't overwork this with our limited maintenance time though and it will be a compromise no matter what and its not sure my preference is most sensible. If you are ready, lets merge! The pypi password is already setup ahead of time for this repo! |
consideRatio
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See jupyterhub/team-compass#353
This is based on https://github.com/jupyterhub/oauthenticator/tree/be91e7d9e58f13221615a64a506529c775abe593/.github/workflows
The main changes from the Travis configuration are: