Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape user- or ldap-provided strings in ldap search filters #238

Merged
merged 3 commits into from
Sep 14, 2024

Conversation

m-erhardt
Copy link
Contributor

Escape all user- or ldap-provided fields in ldap search queries in accordance with RFC4515 to prevent malformed LDAP filter (ldap3.core.exceptions.LDAPInvalidFilterError: malformed filter)
Fixes #237

@consideRatio
Copy link
Member

Nice! I've now concluded this makes sense and verified that without this I run into an error but with it I don't - thanks for a great writeup in #237 @m-erhardt!!

@consideRatio consideRatio merged commit cf6d3ae into jupyterhub:main Sep 14, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LDAP search strings not escaped correctly
2 participants