refactor: specify param names for Connection.search consistently #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
changed the title
consideRatio
force-pushed
the
pr/specify-arg-names
branch
from
97d1441 to
c7650a6
Compare
consideRatio
commented
Sep 16, 2024
| @@ -397,7 +397,10 @@ def get_user_attributes(self, conn, userdn): | |||
| attrs = {} | |||
| if self.auth_state_attributes: | |||
| found = conn.search( | |||
| userdn, "(objectClass=*)", attributes=self.auth_state_attributes | |||
| search_base=userdn, | |||
| search_scope=ldap3.SUBTREE, | |||
There was a problem hiding this comment.
SUBTREE is the default value, specified explicitly as it were other places.
| @@ -397,7 +397,10 @@ def get_user_attributes(self, conn, userdn): | |||
| attrs = {} | |||
| if self.auth_state_attributes: | |||
| found = conn.search( | |||
| userdn, "(objectClass=*)", attributes=self.auth_state_attributes | |||
| search_base=userdn, | |||
There was a problem hiding this comment.
Understanding that this param was search_base helped me understand things better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just small details that helps me read and understand this code base, and possibly others then.