tests: pass config to constructor instead of configuring after #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
force-pushed
the
pr/tests-config-construct
branch
from
a199906 to
6fdea8e
Compare
consideRatio
force-pushed
the
pr/tests-config-construct
branch
from
6fdea8e to
4cf07bc
Compare
This was referenced Sep 23, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our tests previously was written in a way what created a blank authenticator object, and then configured it one config at the time. I want to transition away from that, as it makes traitlets verification of config error if any of the incremental configuration steps after the authenticator object is initialized are invalid - even though the final configuration won't be.
By this change, we align better with how users are going to use their authentication class which is typically initialized by jupyterhub itself based on config provided, rather than initialized without provided config and then updated.