Docs updates, and a few tweaks to the allow config #286
+22
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s used downstream
manics
commented
Sep 28, 2024
| @@ -264,7 +266,7 @@ def _ensure_allowed_groups_requirements(self, change): | |||
| c.LDAPAuthenticator.lookup_dn_search_password = 'secret' | |||
| c.LDAPAuthenticator.user_search_base = 'ou=people,dc=wikimedia,dc=org' | |||
| c.LDAPAuthenticator.user_attribute = 'uid' | |||
| c.LDAPAuthenticator.lookup_dn_user_dn_attribute = 'cn' | |||
| c.LDAPAuthenticator.lookup_dn_user_dn_attribute = 'sAMAccountName' | |||
There was a problem hiding this comment.
I presume this is meant to be an AD example, and this should never be cn? Or should it be uid?
| ) | ||
| username = username[0] |
There was a problem hiding this comment.
When is it acceptable to return just the first match?
manics
commented
Sep 28, 2024
| # if all groups are needed (e.g. for manage_groups) | ||
| # we should keep fetching membership | ||
| break | ||
| # Returned in auth_state, so fetch the full list |
There was a problem hiding this comment.
An alternative, if we don't want to iterate through all groups, is to change the property to is_in_allowed_groups: true|false
minrk
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More details in commit messages.