Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Replace Travis with GitHub workflow #161

Merged
merged 4 commits into from
Dec 11, 2020
Merged

CI: Replace Travis with GitHub workflow #161

merged 4 commits into from
Dec 11, 2020

Conversation

manics
Copy link
Member

@manics manics commented Dec 11, 2020

See jupyterhub/team-compass#353

This is based on https://github.com/jupyterhub/oauthenticator/tree/be91e7d9e58f13221615a64a506529c775abe593/.github/workflows

The main changes from the Travis configuration are:

  • Changed Tox from Python 3.7 to 3.8
  • Pypi publishing of tags is independent of test status

@manics
Copy link
Member Author

manics commented Dec 11, 2020

This will require PyPI secrets to be setup

@manics manics requested a review from consideRatio December 11, 2020 13:42
@consideRatio
Copy link
Member

consideRatio commented Dec 11, 2020 •
edited
Loading

Excellent! This LGTM also, pypi_password already setup also!

Ready to merge? Go for a self merge! It is so fresh so i didnt dare without confirmation.

@consideRatio consideRatio merged commit 92e2b7f into jupyterhub:master Dec 11, 2020
@manics manics deleted the github-workflow branch December 11, 2020 18:53
@consideRatio consideRatio added the ci label Jun 9, 2021
@consideRatio consideRatio changed the title Replace Travis with GitHub workflow CI: Replace Travis with GitHub workflow Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@consideRatio consideRatio Awaiting requested review from consideRatio

Assignees
No one assigned
Labels
ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manics @consideRatio